Shubhendu Tripathi has posted comments on this change. Change subject: gluster: VDS Command - Gluster vol snapshot create ......................................................................
Patch Set 23: (2 comments) http://gerrit.ovirt.org/#/c/23212/23/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeCreateSnapshotVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeCreateSnapshotVDSParameters.java: Line 1: package org.ovirt.engine.core.common.vdscommands.gluster; Line 2: Line 3: import org.ovirt.engine.core.compat.Guid; Line 4: Line 5: public class GlusterVolumeCreateSnapshotVDSParameters extends GlusterVolumeVDSParameters { > not very important, but why params are GlusterVolumeCreateSnapshot while th Got it. For uniformity sake I will rename to CreateGlusterVolumeSnapshotVDSParameters :) Line 6: protected String snapshotName; Line 7: protected String description; Line 8: protected boolean force; Line 9: Line 42: } Line 43: Line 44: public void setForce(boolean force) { Line 45: this.force = force; Line 46: } > there is an infrastructure for VDSCommands that print the parameters of com Sure. Would do this for VDS command patches. -- To view, visit http://gerrit.ovirt.org/23212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib610f49c3b6c5aa108ce6fef0291cd9693429197 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
