Omer Frenkel has posted comments on this change. Change subject: gluster: VDS Command - Gluster vol snapshot create ......................................................................
Patch Set 23: (2 comments) looks ok, minor comments http://gerrit.ovirt.org/#/c/23212/23/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeCreateSnapshotVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeCreateSnapshotVDSParameters.java: Line 1: package org.ovirt.engine.core.common.vdscommands.gluster; Line 2: Line 3: import org.ovirt.engine.core.compat.Guid; Line 4: Line 5: public class GlusterVolumeCreateSnapshotVDSParameters extends GlusterVolumeVDSParameters { not very important, but why params are GlusterVolumeCreateSnapshot while the command is CreateGlusterVolumeSnapshot ? Line 6: protected String snapshotName; Line 7: protected String description; Line 8: protected boolean force; Line 9: Line 42: } Line 43: Line 44: public void setForce(boolean force) { Line 45: this.force = force; Line 46: } there is an infrastructure for VDSCommands that print the parameters of commands when they are called, for example if you look at the log for stop vm you will see: 2015-02-18 13:12:13,723 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.DestroyVDSCommand] (DefaultQuartzScheduler_Worker-26) START, DestroyVDSCommand(HostName = h1, HostId = 3df69dc7-dbb8-4f24-a41a-3ad6de 6d8368, vmId=0351b54b-bfb3-476d-a477-208b71768ec8, force=false, secondsToWait=0, gracefully=false), log id: 267fa7cb this is done just by overriding the toString method and printing the parameters values, you can see example in DestroyVmVDSCommandParameters (or almost any VDSCommand parameters class) this is not a must but i recommend to use it for better debugging, because this way, when looking at the engine log, you can see the values sent to vdsm on each call -- To view, visit http://gerrit.ovirt.org/23212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib610f49c3b6c5aa108ce6fef0291cd9693429197 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
