Greg Sheremeta has posted comments on this change.

Change subject: userportal, webadmin: convert LabelWithTextTruncation to use 
PatternFly tooltips
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/37762/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextTruncation.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextTruncation.java:

Line 77: 
Line 78:     @Override
Line 79:     public void setEnabled(boolean enabled) {
Line 80:         this.enabled = enabled;
Line 81:         getElement().getStyle().setColor(enabled ? "#333333" : 
"gray"); //$NON-NLS-1$ //$NON-NLS-2$
> This change isn't needed.
My Eclipse says otherwise! :)
Line 82:     }


-- 
To view, visit http://gerrit.ovirt.org/37762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c22d5003c26ef2df418d2df7c76af009ab383e4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to