Lior Vernia has posted comments on this change. Change subject: userportal, webadmin: convert LabelWithTextTruncation to use PatternFly tooltips ......................................................................
Patch Set 3: Code-Review+2 (2 comments) Fine by me if it's verified. http://gerrit.ovirt.org/#/c/37762/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextTruncation.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextTruncation.java: Line 77: Line 78: @Override Line 79: public void setEnabled(boolean enabled) { Line 80: this.enabled = enabled; Line 81: getElement().getStyle().setColor(enabled ? "#333333" : "gray"); //$NON-NLS-1$ //$NON-NLS-2$ This change isn't needed. Line 82: } http://gerrit.ovirt.org/#/c/37762/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/WidgetTooltip.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/WidgetTooltip.java: Line 20: init(); Line 21: } Line 22: Line 23: private void init() { Line 24: this.setIsAnimated(TooltipConfig.IS_ANIMATED); "this" is redundant in all these rows, consider removing. Line 25: this.setPlacement(TooltipConfig.PLACEMENT); Line 26: this.setIsHtml(TooltipConfig.IS_HTML); Line 27: this.setTrigger(TooltipConfig.TRIGGER); Line 28: this.setShowDelayMs(TooltipConfig.SHOW_DELAY_MS); -- To view, visit http://gerrit.ovirt.org/37762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c22d5003c26ef2df418d2df7c76af009ab383e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
