anmolbabu has posted comments on this change. Change subject: engine : bll command to set geo-rep config ......................................................................
Patch Set 11: (3 comments) http://gerrit.ovirt.org/#/c/35999/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionConfiguration.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionConfiguration.java: Line 43: @Override Line 44: public boolean equals(Object obj) { Line 45: return obj != null && obj instanceof GlusterGeoRepSessionConfiguration Line 46: && ObjectUtils.objectsEqual(getId(), ((GlusterGeoRepSessionConfiguration) obj).getId()) Line 47: && ObjectUtils.haveSameElements(allowedValues, > Should allowedValues be considered for object equality? Done. I think I got your point Line 48: ((GlusterGeoRepSessionConfiguration) obj).getAllowedValues()) Line 49: && super.equals(obj); Line 50: } Line 51: http://gerrit.ovirt.org/#/c/35999/11/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java: Line 226: public void saveOrUpdateDetailsInBatch(List<GlusterGeoRepSessionDetails> geoRepSessionDetailsObjs) { Line 227: List<GlusterGeoRepSessionDetails> insertList = new ArrayList<>(); Line 228: List<GlusterGeoRepSessionDetails> updateList = new ArrayList<>(); Line 229: for (GlusterGeoRepSessionDetails details : geoRepSessionDetailsObjs) Line 230: if (getGeoRepSessionDetails(details.getSessionId(), details.getMasterBrickId()) == null) > Apply default formatter Done Line 231: insertList.add(details); Line 232: else Line 233: updateList.add(details); Line 234: saveDetailsInBatch(insertList); http://gerrit.ovirt.org/#/c/35999/11/packaging/dbscripts/upgrade/03_06_0830_add_config_table.sql File packaging/dbscripts/upgrade/03_06_0830_add_config_table.sql: Line 1: CREATE TABLE config_details > config_details or gluster_config_master? Done Line 2: ( Line 3: config_key VARCHAR(50), Line 4: config_description VARCHAR(300), Line 5: minimum_supported_cluster VARCHAR(50), -- To view, visit http://gerrit.ovirt.org/35999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d98636a688f9565dff0c86c8820839cb99b1a38 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
