anmolbabu has posted comments on this change. Change subject: engine : bll command to set geo-rep config ......................................................................
Patch Set 8: (4 comments) I'll incorporate these in the following patch set http://gerrit.ovirt.org/#/c/35999/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetDefaultGeoRepConfigCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetDefaultGeoRepConfigCommand.java: Line 27: session.getMasterVolumeName(), Line 28: session.getSlaveHostName(), Line 29: session.getSlaveVolumeName(), Line 30: getParameters().getConfigKey())); Line 31: setSucceeded(returnValue.getSucceeded()); > Shouldn't the db be updated with default value once succeeded? Default value is not known until it is set in cli Line 32: if (!getSucceeded()) { Line 33: handleVdsError(AuditLogType.GLUSTER_GEOREP_CONFIG_SET_DEFAULT_FAILED, returnValue.getVdsError() Line 34: .getMessage()); Line 35: return; Line 55: } Line 56: Line 57: @Override Line 58: public AuditLogType getAuditLogTypeValue() { Line 59: if (getSucceeded()) > the default standard is to use curly braces Done. My eclipse save preference :( Line 60: return AuditLogType.GLUSTER_GEOREP_CONFIG_SET_DEFAULT; Line 61: else Line 62: return errorType == null ? AuditLogType.GLUSTER_GEOREP_CONFIG_SET_DEFAULT_FAILED : errorType; Line 63: } http://gerrit.ovirt.org/#/c/35999/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java: Line 68: } Line 69: Line 70: @Override Line 71: public AuditLogType getAuditLogTypeValue() { Line 72: if(getSucceeded()) > same comment as before Done Line 73: return AuditLogType.GLUSTER_GEOREP_CONFIG_SET; Line 74: else Line 75: return errorType == null ? AuditLogType.GLUSTER_GEOREP_CONFIG_SET_FAILED : errorType; Line 76: } http://gerrit.ovirt.org/#/c/35999/8/packaging/dbscripts/upgrade/03_06_0840_insert_config_description.sql File packaging/dbscripts/upgrade/03_06_0840_insert_config_description.sql: Line 8: values('log-file', 'The path to the geo-replication log file.', '3.5', '', 'geo_replication'); Line 9: Line 10: INSERT INTO config_details(config_key, config_description, minimum_supported_cluster, config_possible_values, config_feature) Line 11: values('log-level', 'The log level for geo-replication.', '3.5', '', 'geo_replication'); Line 12: > TWS Done Line 13: INSERT INTO config_details(config_key, config_description, minimum_supported_cluster, config_possible_values, config_feature) Line 14: values('ssh-command', 'The SSH command to connect to the remote machine', '3.5', '', 'geo_replication'); Line 15: Line 16: INSERT INTO config_details(config_key, config_description, minimum_supported_cluster, config_possible_values, config_feature) -- To view, visit http://gerrit.ovirt.org/35999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d98636a688f9565dff0c86c8820839cb99b1a38 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
