Martin Mucha has posted comments on this change. Change subject: core, restapi: reporting & removal of unmanaged networks. ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/37525/4/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UnmanagedNetworkMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UnmanagedNetworkMapper.java: Line 13: Line 14: UnmanagedNetworkBusinessEntity entity = template == null ? new UnmanagedNetworkBusinessEntity() : template; Line 15: Line 16: if (model.isSetId()) { Line 17: entity.setId(model.getUnmanagedNetworkName()); > Note that I think that searching by name (or by any other criteria) in a co alright; I think that querying is not necessary like Juan said, since there won't be lot of records (there ideally should be none). Sorry for verbose chat, I had to ask about requested solution and not 'encrypting' names seemed better to me. Changed to HEX. Done. Line 18: } Line 19: Line 20: if (model.isSetUnmanagedNetworkName()) { Line 21: entity.setNetworkName(model.getUnmanagedNetworkName()); -- To view, visit http://gerrit.ovirt.org/37525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcf6e1292ce6f3a335051123be8c3389e8230bf0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
