Martin Mucha has posted comments on this change.

Change subject: core, restapi: reporting & removal of unmanaged networks.
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/37525/5/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UnmanagedNetworkMapper.java
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UnmanagedNetworkMapper.java:

Line 18: 
Line 19:         UnmanagedNetworkBusinessEntity entity = template == null ? new 
UnmanagedNetworkBusinessEntity() : template;
Line 20: 
Line 21:         if (model.isSetId()) {
Line 22:             entity.setId(decodeNetworkName(model.getName()));
> Encoding and decoding of names provided by the backend must be done with th
no problem, I just had to ask. Done.
Line 23:         }
Line 24: 
Line 25:         if (model.isSetName()) {
Line 26:             entity.setNetworkName(model.getName());


-- 
To view, visit http://gerrit.ovirt.org/37525
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcf6e1292ce6f3a335051123be8c3389e8230bf0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to