Ayal Baron has posted comments on this change.
Change subject: core : create template from VM with no snappable disks (#841534)
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 139: return null;
Line 140: }
Line 141: });
Line 142:
Line 143: // means that there are no asynchronous tasks to execute and
that we can
Instead of this comment which would go stale just make the code self
explanatory:
Boolean pendingAsyncTasks = getReturnValue().getTaskIdList().isEmpty()
if (!pendingAsyncTasks) {
endSuccess...
}
Line 144: // end the command synchronously
Line 145: if (getReturnValue().getTaskIdList().isEmpty()) {
Line 146: endSuccessfullySynchronous();
Line 147: }
Line 386: UpdateTemplateInSpm(template.getstorage_pool_id().getValue(),
new java.util.ArrayList<VmTemplate>(
Line 387: java.util.Arrays.asList(new VmTemplate[] { template
})));
Line 388: }
Line 389:
Line 390: private void endUnlockRelatedOperations() {
s/endUnlockRelatedOperations/endUnlockOps/
Line 391: VmHandler.UnLockVm(getVm());
Line 392: VmTemplateHandler.UnLockVmTemplate(getVmTemplateId());
Line 393: }
Line 394:
--
To view, visit http://gerrit.ovirt.org/6593
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie825ea39fee6d6d5c86f9c82f3008fa314392ed2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
