Allon Mureinik has posted comments on this change.
Change subject: core : create template from VM with no snappable disks (#841534)
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 362:
Line 363: for (VdcActionParametersBase p :
getParameters().getImagesParameters()) {
Line 364:
Backend.getInstance().EndAction(VdcActionType.CreateImageTemplate, p);
Line 365: }
Line 366: if (reloadVmTemplateFromDB() != null) {
why not replace this entire block with endSuccessfullySynchronous()?
Line 367: endDefaultOperations();
Line 368: }
Line 369: setSucceeded(true);
Line 370: }
--
To view, visit http://gerrit.ovirt.org/6593
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie825ea39fee6d6d5c86f9c82f3008fa314392ed2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
