Francesco Romani has posted comments on this change. Change subject: guest manager: add monitor de/registration methods ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/31605/4/mom/GuestManager.py File mom/GuestManager.py: Line 129: return ret Line 130: Line 131: def _register_guest(self, uuid, guest, thread): Line 132: if uuid not in self.guests: Line 133: self.guests[uuid] = (guest, thread) > How about using a namedtuple for the monitor, thread pair? Probably nicer, will change. Line 134: else: Line 135: del guest Line 136: del thread Line 137: -- To view, visit http://gerrit.ovirt.org/31605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67dd35aa491f47dbcb926ae3a1e4e0fb94527f84 Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
