Piotr Kliczewski has posted comments on this change. Change subject: core: [WIP] [NON AS7.1.1] custom jboss login plugin using digest ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29693/4/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/jboss_auth_plugin/OvirtAuthPlugInProvider.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/jboss_auth_plugin/OvirtAuthPlugInProvider.java: Line 12: } Line 13: return null; Line 14: } Line 15: Line 16: @Override public AuthorizationPlugIn loadAuthorizationPlugIn(String s) { Do we want to required specific roles? I am not sure whether all the users should be able to use jmx. Line 17: return null; Line 18: } -- To view, visit http://gerrit.ovirt.org/29693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e504c9b429f7fe02d42b0170e6e3a08b801efae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
