Roy Golan has posted comments on this change. Change subject: core: make DbFacade a CDI singleton ......................................................................
Patch Set 44: (1 comment) http://gerrit.ovirt.org/#/c/34814/44/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java: Line 173: import org.springframework.jdbc.core.namedparam.MapSqlParameterSource; Line 174: import org.springframework.jdbc.core.simple.SimpleJdbcCall; Line 175: Line 176: @Named Line 177: @Singleton the Named adds nothing actuall. Singleton is anough. if you just put @Named than the default CDI scope would be @Dependant - which means it would be created each time the holding object is created. can you confirm you're aren't using @Named alone somewhere? Line 178: public class DbFacade { Line 179: Line 180: private final static Logger log = LoggerFactory.getLogger(DbFacade.class); Line 181: -- To view, visit http://gerrit.ovirt.org/34814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9e57710ce8353af020cb5ae53e43b127276d6c6 Gerrit-PatchSet: 44 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
