Yevgeny Zaspitsky has posted comments on this change. Change subject: core: make DbFacade a CDI singleton ......................................................................
Patch Set 37: (1 comment) http://gerrit.ovirt.org/#/c/34814/37/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ModuleConfigurationExtension.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ModuleConfigurationExtension.java: Line 52: Line 53: if (foundBeans.size() == 0) { Line 54: bdd.addAnnotatedType(annotatedType); Line 55: String name; Line 56: Named named = bean.getAnnotation(Named.class); > The simple solution for bean discovery. I agree with Roy. AFAIK @Named is a qualifier for bean resolution but is not necessarily being used. When we will have a newer Jboss with no CDI bug and will remove this workaround will @Named with no other bean definition work with the standard CDI? Line 57: if (named == null || Strings.isNullOrEmpty(named.value())) { Line 58: name = bean.getSimpleName(); Line 59: } else { Line 60: name = named.value(); -- To view, visit http://gerrit.ovirt.org/34814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9e57710ce8353af020cb5ae53e43b127276d6c6 Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
