Yevgeny Zaspitsky has posted comments on this change. Change subject: webadmin: update how mgmt network being selected for a new Vnic profile ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/37032/17/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java: Line 496: return ret; Line 497: } Line 498: Line 499: private static boolean isManagementNetwork(Network network) { Line 500: return network.getCluster() != null && network.getCluster().isManagement(); > This null check is unnecessary, this method is only meaningful in cluster c Done Line 501: } Line 502: Line 503: public static Network findManagementNetwork(List<Network> networks) { Line 504: for (Network network : networks) { -- To view, visit http://gerrit.ovirt.org/37032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac4536cd0394999e128d4448014ebbcc2930ffdf Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
