Yevgeny Zaspitsky has posted comments on this change.

Change subject: webadmin: update how mgmt network being selected for a new Vnic 
profile
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/37032/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ProfileBehavior.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ProfileBehavior.java:

Line 17: 
Line 18: public abstract class ProfileBehavior {
Line 19: 
Line 20:     private List<Network> clusterNetworks = new ArrayList<Network>();
Line 21:     private Network managementNetwork;
> I think you don't need the entire network, its name will be enough for your
Done
Line 22: 
Line 23:     public void initProfiles(final boolean hotUpdateSupported,
Line 24:             final Guid clusterId,
Line 25:             final Guid dcId,


-- 
To view, visit http://gerrit.ovirt.org/37032
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac4536cd0394999e128d4448014ebbcc2930ffdf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to