Liron Aravot has posted comments on this change. Change subject: core : Change ImageSpmCommand to not use placeholder mechanism ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/37149/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImageSpmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImageSpmCommand.java: Line 76: protected void executeCommand() { Line 77: VDSReturnValue vdsReturnValue = executeVdsCommand(); Line 78: Line 79: if (vdsReturnValue.getSucceeded()) { Line 80: Guid taskId = persistAsyncTaskPlaceHolder(getParameters().getParentCommand()); > We are only getting rid of inserting all child place holders. Here we inser I understand, but if we don't use the placeholders..why do we need to insert them at all? how do we use them? Also, i'm not 100% understand why do we get rid of that infra - the reason that we added it in the first place and not used a flag IIRC is to have further information (that's more easy to get) on what was created and what not..not just to know if the executed part was completed. Line 81: getReturnValue().getInternalVdsmTaskIdList().add(createTask(taskId, Line 82: vdsReturnValue.getCreationInfo(), Line 83: getParameters().getParentCommand(), Line 84: VdcObjectType.Storage, -- To view, visit http://gerrit.ovirt.org/37149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I897c9c3cf9e39000f2f2a90b26e01fff7861582c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
