Ravi Nori has posted comments on this change. Change subject: core : Change ImageSpmCommand to not use placeholder mechanism ......................................................................
Patch Set 2: @Kiron We are dropping the placeholder mechanism where the parent command before its execute method inserts placeholders for all its child commands. Now with the new executed flag for a command, we can determine if the execute phase of the command has completed successfully and handle the command using flag. It is no longer necessary to insert place holders. -- To view, visit http://gerrit.ovirt.org/37149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I897c9c3cf9e39000f2f2a90b26e01fff7861582c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
