Shubhendu Tripathi has posted comments on this change. Change subject: engine : Entity and DAO changes for Disk provisioning ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/36428/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageDevice.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageDevice.java: Line 151: return result; Line 152: } Line 153: Line 154: @Override Line 155: public boolean equals(Object obj) { Better use ObjectUtils.objectsEqual() method for this purpose. Refer existing entities. Line 156: if (this == obj) Line 157: return true; Line 158: if (obj == null) Line 159: return false; http://gerrit.ovirt.org/#/c/36428/3/packaging/dbscripts/storage_device_sp.sql File packaging/dbscripts/storage_device_sp.sql: Line 54: WHERE id = v_id; Line 55: END; $procedure$ Line 56: LANGUAGE plpgsql; Line 57: Line 58: Create or replace FUNCTION GetStorageDeviceById(v_id UUID) Should we join with hosts table and return host_id as well ?? Line 59: RETURNS SETOF storage_device STABLE Line 60: AS $procedure$ Line 61: BEGIN Line 62: RETURN QUERY SELECT * Line 83: WHERE id = v_id; Line 84: END; $procedure$ Line 85: LANGUAGE plpgsql; Line 86: Line 87: Create or replace FUNCTION DeleteStorageDeviceByIds(v_ids VARCHAR(5000)) Is this used in DaoImpl ?? Line 88: RETURNS VOID Line 89: AS $procedure$ Line 90: BEGIN Line 91: DELETE FROM storage_device -- To view, visit http://gerrit.ovirt.org/36428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95a12239429dd0c7f3282161221e8b8f639cee9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
