Eli Mesika has posted comments on this change. Change subject: engine : Entity and DAO changes for Disk provisioning ......................................................................
Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36428/4/packaging/dbscripts/storage_device_sp.sql File packaging/dbscripts/storage_device_sp.sql: Line 83: WHERE id = v_id; Line 84: END; $procedure$ Line 85: LANGUAGE plpgsql; Line 86: Line 87: Create or replace FUNCTION DeleteStorageDeviceByIds(v_ids VARCHAR(5000)) This is not he right way to do batch delete Please look at usages of MassOperationsDao::removeAllInBatch Line 88: RETURNS VOID Line 89: AS $procedure$ Line 90: BEGIN Line 91: DELETE FROM storage_device -- To view, visit http://gerrit.ovirt.org/36428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95a12239429dd0c7f3282161221e8b8f639cee9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
