Ravi Nori has posted comments on this change. Change subject: core : Change CreateAllSnapshotsFromVmCommand to not use placeholders mechanism ......................................................................
Patch Set 2: @Arik Very good point, since the parent command has not completed its execute phase its execute flag is false. So the one task that has been executed will endWithFailure because of the root commands executed=false. No issue here, verified it. -- To view, visit http://gerrit.ovirt.org/37146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a6bba5d34e49efc06803ae042de9eb92fa3bc2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
