Arik Hadas has posted comments on this change. Change subject: core : Change CreateAllSnapshotsFromVmCommand to not use placeholders mechanism ......................................................................
Patch Set 2: Code-Review-1 what happens now in the following scenario: 1. command creates one task in the execute method 2. the engine crash before it creates other task it would create if the was not crashed (the engine crashed in the middle of the execute method) 3. when engine starts it finds that the created task was finished successfully will endWithFailure be called or the endSuccessfully method will be called, assuming the command checks the execution status (executed/not executed) ? -- To view, visit http://gerrit.ovirt.org/37146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a6bba5d34e49efc06803ae042de9eb92fa3bc2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
