Francesco Romani has uploaded a new change for review.
Change subject: vdsm: use new VDSM APIs to improve efficiency
......................................................................
vdsm: use new VDSM APIs to improve efficiency
This patch makes use of new (private) VDSM APIs
to improve efficiency.
No changes in behaviour are expected.
Change-Id: Iac5241e20c1e35866bfbb5a643ae00e463dcac2e
Signed-off-by: Francesco Romani <from...@redhat.com>
---
M mom/HypervisorInterfaces/vdsmInterface.py
1 file changed, 10 insertions(+), 36 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/mom refs/changes/80/37180/1
diff --git a/mom/HypervisorInterfaces/vdsmInterface.py
b/mom/HypervisorInterfaces/vdsmInterface.py
index 1193785..2e60812 100644
--- a/mom/HypervisorInterfaces/vdsmInterface.py
+++ b/mom/HypervisorInterfaces/vdsmInterface.py
@@ -45,39 +45,12 @@
if response['status']['code']:
raise vdsmException(response, self.logger)
- def _vmIsRunning(self, vm):
- if vm['status'] == 'Up':
- return True
- else:
- return False
-
- def getVmName(self, uuid):
- try:
- response = self.vdsm_api.getVMList(True, [uuid])
- self._check_status(response)
- return response['vmList'][0]['vmName']
- except vdsmException, e:
- e.handle_exception()
- return None
-
- def getVmPid(self, uuid):
- try:
- response = self.vdsm_api.getVMList(True, [uuid])
- self._check_status(response)
- return response['vmList'][0]['pid']
- except vdsmException, e:
- e.handle_exception()
- return None
-
def getVmList(self):
vmIds = []
try:
- response = self.vdsm_api.getVMList()
+ response = self.vdsm_api.getVMListByStatus('Up')
self._check_status(response)
- vm_list = response['vmList']
- for vm in vm_list:
- if self._vmIsRunning(vm):
- vmIds.append(vm['vmId'])
+ vmIds = response['vmList']
self.logger.debug('VM List: %s', vmIds)
return vmIds
except vdsmException, e:
@@ -125,14 +98,15 @@
except vdsmException, e:
e.handle_exception()
- def getVmInfo(self, id):
- data = {}
- data['uuid'] = id
- data['pid'] = self.getVmPid(id)
- data['name'] = self.getVmName(id)
- if None in data.values():
+ def getVmInfo(self, uuid):
+ try:
+ response = self.vdsm_api.getStatus(uuid)
+ self._check_status(response)
+ except vdsmException, e:
+ e.handle_exception()
return None
- return data
+ else:
+ return response['data']
def getStatsFields(self=None):
return set(['mem_available', 'mem_unused', 'mem_free',
--
To view, visit http://gerrit.ovirt.org/37180
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac5241e20c1e35866bfbb5a643ae00e463dcac2e
Gerrit-PatchSet: 1
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
