Ravi Nori has uploaded a new change for review.
Change subject: core : Change HibernateVmCommand to not use placeholders
mechanism
......................................................................
core : Change HibernateVmCommand to not use placeholders mechanism
HibernateVmCommand has been changed not
to insert placeholders for all child commands before
execution by vdsm
Change-Id: Ifc33acd404a835a98d315bed6a0195966a44ee25
Signed-off-by: Ravi Nori <rn...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
1 file changed, 2 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/48/37148/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
index 090ed24..7cd2995 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
@@ -73,12 +73,6 @@
return lockProperties.withScope(Scope.Execution);
}
- @Override
- protected void insertAsyncTaskPlaceHolders() {
- persistAsyncTaskPlaceHolder(getParameters().getParentCommand(),
SAVE_IMAGE_TASK_KEY);
- persistAsyncTaskPlaceHolder(getParameters().getParentCommand(),
SAVE_RAM_STATE_TASK_KEY);
- }
-
/**
* Finds an active data/master storage domain which has enough space to
store the hibernation volumes
*
@@ -116,7 +110,7 @@
}
});
- final Guid taskId1 = getAsyncTaskId(SAVE_IMAGE_TASK_KEY);
+ final Guid taskId1 =
persistAsyncTaskPlaceHolder(VdcActionType.HibernateVm, SAVE_IMAGE_TASK_KEY);
Guid image1GroupId = Guid.newGuid();
@@ -154,7 +148,7 @@
getReturnValue().getVdsmTaskIdList().add(guid1);
- Guid taskId2 = getAsyncTaskId(SAVE_RAM_STATE_TASK_KEY);
+ Guid taskId2 = persistAsyncTaskPlaceHolder(VdcActionType.HibernateVm,
SAVE_RAM_STATE_TASK_KEY);
// second vol should be 10kb
Guid image2GroupId = Guid.newGuid();
--
To view, visit http://gerrit.ovirt.org/37148
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc33acd404a835a98d315bed6a0195966a44ee25
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
