Ravi Nori has uploaded a new change for review.

Change subject: core : Change ImageSpmCommand to not use placeholder mechanism
......................................................................

core : Change ImageSpmCommand to not use placeholder mechanism

Change ImageSpmCommand to not use the
place holder mechanism to insert async
task placeholder before the execute
method of the command

Change-Id: I897c9c3cf9e39000f2f2a90b26e01fff7861582c
Signed-off-by: Ravi Nori <rn...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImageSpmCommand.java
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/37149/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImageSpmCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImageSpmCommand.java
index 27b42d2..94653a1 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImageSpmCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImageSpmCommand.java
@@ -29,11 +29,6 @@
         return lockProperties.withScope(Scope.Execution);
     }
 
-    @Override
-    protected void insertAsyncTaskPlaceHolders() {
-        persistAsyncTaskPlaceHolder(getParameters().getParentCommand());
-    }
-
     private Guid getPoolSpmId() {
         if (cachedSpmId == null) {
             cachedSpmId = getStoragePool().getSpmVdsId();
@@ -82,7 +77,7 @@
         VDSReturnValue vdsReturnValue = executeVdsCommand();
 
         if (vdsReturnValue.getSucceeded()) {
-            Guid taskId = getAsyncTaskId();
+            Guid taskId = 
persistAsyncTaskPlaceHolder(getParameters().getParentCommand());
             getReturnValue().getInternalVdsmTaskIdList().add(createTask(taskId,
                     vdsReturnValue.getCreationInfo(),
                     getParameters().getParentCommand(),


-- 
To view, visit http://gerrit.ovirt.org/37149
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I897c9c3cf9e39000f2f2a90b26e01fff7861582c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to