Omer Frenkel has posted comments on this change.

Change subject: core: Introduce ChangeQuotaCommand - disks (#848310)
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
Line 59:     VAR__ACTION__HOT_UNPLUG,
Line 60:     VAR__ACTION__LOGON,
Line 61:     VAR__ACTION__LOGOFF,
Line 62:     VAR__ACTION__REBALANCE_START,
Line 63:     VAR__ACTION__ASSIGN,
where is this used?
Line 64: 
Line 65:     // Host statuses replacements
Line 66:     VAR__HOST_STATUS__UP,
Line 67:     VAR__HOST_STATUS__UP_MAINTENANCE_OR_NON_OPERATIONAL,


....................................................
File 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 686:     String VAR__ACTION__LOGOFF();
Line 687: 
Line 688:     @DefaultStringValue("$action rebalance")
Line 689:     String VAR__ACTION__REBALANCE_START();
Line 690:     
remove white space (or remove this entry as i don't see it's used)
Line 691:     @DefaultStringValue("$action Assign")
Line 692:     String VAR__ACTION__ASSIGN();
Line 693: 
Line 694:     @DefaultStringValue("$hostStatus Up")


--
To view, visit http://gerrit.ovirt.org/7357
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0017a18109faecd1acab52897bba5474b6600390
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to