Tal Nisan has posted comments on this change. Change subject: webadmin: When creating LUN disk populate the description with the LUN id ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/37088/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java: Line 461: LunModel selectedLunModel = (LunModel) sender; Line 462: Line 463: if (!selectedLunModel.getIsSelected() || !getItems().iterator().hasNext()) { Line 464: return; Line 465: } > Removing the newline here seems unrelated to the patch. Done Line 466: // Clear LUNs selection Line 467: for (Model model : (List<Model>) getItems()) { Line 468: if (model instanceof LunModel) { Line 469: LunModel lunModel = (LunModel) model; http://gerrit.ovirt.org/#/c/37088/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java: Line 213: else { Line 214: newDescription = selectedLunModel.getLunId().substring(selectedLunModel.getLunId().length() - numOfChars); Line 215: } Line 216: getDescription().setEntity(newDescription); Line 217: descriptionDerivedFromLunId = true; > Why do we need this? Explained f2f Line 218: } Line 219: } Line 220: } Line 221: }); http://gerrit.ovirt.org/#/c/37088/2/packaging/etc/engine-config/engine-config.properties File packaging/etc/engine-config/engine-config.properties: Line 21: CpuOverCommitDurationMinutes.description="The duration in minutes of CPU consumption to activate selection algorithm" Line 22: CpuOverCommitDurationMinutes.type=Integer Line 23: DisableFenceAtStartupInSec.description="Disable Fence Operations At oVirt Startup In Seconds" Line 24: DisableFenceAtStartupInSec.type=Integer Line 25: PopulateDirectLUNDiskDescriptionWithLUNId.description="When creating direct LUN disk the number of characters from LUN id to populate the description with (-1 = the full id, 0 = none, <1 = number of characters)" > It's >= 1, not <1 Done Line 26: PopulateDirectLUNDiskDescriptionWithLUNId.type=Integer Line 27: ClusterEmulatedMachines.description="Supported machine types" Line 28: WANDisableEffects.description="Disabled WAN Effects value to send to the SPICE console" Line 29: WANDisableEffects.validValues=animation,wallpaper,font-smooth,all -- To view, visit http://gerrit.ovirt.org/37088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife497d61e4799dec5db6b8fc5007cac743969b2b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
