Allon Mureinik has posted comments on this change. Change subject: webadmin: When creating LUN disk populate the description with the LUN id ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37088/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java: Line 201: if (description == null || description.isEmpty() || Line 202: (!description.isEmpty() && descriptionDerivedFromLunId)) { Line 203: LunModel selectedLunModel = ((ValueEventArgs<LunModel>) args).getValue(); Line 204: if (selectedLunModel.getLunId() != null) { Line 205: String newDescription = selectedLunModel.getLunId().substring(selectedLunModel.getLunId().length() - 4); Four characters is an arbitrary decision. I'd either shove the whole lun ID there, or make it configurable. Line 206: getDescription().setEntity(newDescription); Line 207: descriptionDerivedFromLunId = true; Line 208: } Line 209: } -- To view, visit http://gerrit.ovirt.org/37088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife497d61e4799dec5db6b8fc5007cac743969b2b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
