Lior Vernia has posted comments on this change. Change subject: webadmin: reverted removal of selectedItemsChanged method. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36899/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java: Line 79: removeAllowed = false; Line 80: } else { Line 81: for (MacPool macPool : (Iterable<MacPool>) getSelectedItems()) { Line 82: if (macPool.isDefaultPool()) { Line 83: removeAllowed = false; > just for completeness, in naive JS(no optimizations) and google-chrome and Please don't waste any more time on benchmarking this, of course it's negligible. But it makes the code clearer - it's a statement that finding one default MAC pool is enough (of course there could only be one, but that's beside the point). Line 84: } Line 85: } Line 86: } Line 87: getRemoveCommand().setIsExecutionAllowed(removeAllowed); -- To view, visit http://gerrit.ovirt.org/36899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I473566cf0755519eb7fc922c435ae8a2ee545779 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
