Lior Vernia has posted comments on this change. Change subject: webadmin: reverted removal of selectedItemsChanged method. ......................................................................
Patch Set 1: (2 comments) Looks good, just a couple of small comments. http://gerrit.ovirt.org/#/c/36899/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java: Line 614: protected void selectedItemsChanged() { Line 615: /* Line 616: NOTICE, that there's lot of methods overriding this one, looking 'just like' this one, which seems wrong. Line 617: But notice that all those 'updateActionAvailability()' are private, and does not extends each other. Line 618: Making #updateActionAvailability() protected seems not very straightforward, therefore it's not fixed. This is not the place to suggest refactoring, either send a patch or forget about it :) A shorter comment would do, e.g. "NOTICE: do not remove, superclass implementation doesn't call this class's private updateActionAvailability() method". Line 619: * */ Line 620: super.selectedItemsChanged(); Line 621: updateActionAvailability(); Line 622: } http://gerrit.ovirt.org/#/c/36899/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java: Line 79: removeAllowed = false; Line 80: } else { Line 81: for (MacPool macPool : (Iterable<MacPool>) getSelectedItems()) { Line 82: if (macPool.isDefaultPool()) { Line 83: removeAllowed = false; Isn't directly related to this patch, but maybe add a "break;" line here while we're at it? :) Line 84: } Line 85: } Line 86: } Line 87: getRemoveCommand().setIsExecutionAllowed(removeAllowed); -- To view, visit http://gerrit.ovirt.org/36899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I473566cf0755519eb7fc922c435ae8a2ee545779 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
