Maor Lipchuk has posted comments on this change.

Change subject: core: iSCSI multipath sub tab when SD is in maintenance.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36667/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetConnectionsByDataCenterAndStorageTypeQuery.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetConnectionsByDataCenterAndStorageTypeQuery.java:

Line 23:                                         StorageDomainStatus.Inactive,
Line 24:                                         StorageDomainStatus.Unknown,
Line 25:                                         
StorageDomainStatus.Maintenance,
Line 26:                                         
StorageDomainStatus.PreparingForMaintenance
Line 27:                                         )));
> Let's future-proof and just use EnumSet.allOf(StorageDomainSet.class)
done
Line 28:     }


-- 
To view, visit http://gerrit.ovirt.org/36667
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafaa1010f500dc7c0ec71863fc20127d525bc4ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to