Allon Mureinik has posted comments on this change. Change subject: core: iSCSI multipath sub tab when SD is in maintenance. ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36667/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetConnectionsByDataCenterAndStorageTypeQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetConnectionsByDataCenterAndStorageTypeQuery.java: Line 16: @Override Line 17: protected void executeQueryCommand() { Line 18: getQueryReturnValue().setReturnValue( Line 19: getDbFacade().getStorageServerConnectionDao() Line 20: .getStorageConnectionsByStorageTypeAndStatus(getParameters().getId(), getStorageConnectionsByStorageType is a horrible method that contains business logic in the DAO layer. Having said that, you should just fix it to make sure that the frontend and the backend are aligned. (Or better yet, remove it altogether) Line 21: getParameters().getStorageType(), Line 22: EnumSet.of(StorageDomainStatus.Active, Line 23: StorageDomainStatus.Inactive, Line 24: StorageDomainStatus.Unknown, -- To view, visit http://gerrit.ovirt.org/36667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafaa1010f500dc7c0ec71863fc20127d525bc4ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
