Tal Nisan has posted comments on this change. Change subject: webadmin: Configurable Default for Wipe After Delete per Storage Domain ......................................................................
Patch Set 11: Code-Review-1 (1 comment) Fix the VdcQueryType, other than that code looks fine and passes compilation with tests so just verify functionally and we can merge http://gerrit.ovirt.org/#/c/36526/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 2583: } Line 2584: }; Line 2585: GetStorageDomainDefaultWipeAfterDeleteParameters params = Line 2586: new GetStorageDomainDefaultWipeAfterDeleteParameters(storageType); Line 2587: Frontend.getInstance().runQuery(VdcQueryType.GetStorageDomainWipeAfterDelete, params, aQuery); Change the VdcQueryType to the correct one, this one doesn't exist and thus fails compilation Line 2588: } Line 2589: Line 2590: public void getAllDataCenterNetworks(AsyncQuery aQuery, Guid storagePoolId) { Line 2591: aQuery.converterCallback = new IAsyncConverter() { -- To view, visit http://gerrit.ovirt.org/36526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0bf6a95eb4b33867de86e99f8cb59eec0d1cdd4 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
