Tal Nisan has posted comments on this change. Change subject: webadmin: Configurable Default for Wipe After Delete per Storage Domain ......................................................................
Patch Set 8: (7 comments) http://gerrit.ovirt.org/#/c/36526/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStorageDomainWipeAfterDeleteQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStorageDomainWipeAfterDeleteQuery.java: Line 2: Line 3: import org.ovirt.engine.core.bll.utils.WipeAfterDeleteUtils; Line 4: import org.ovirt.engine.core.common.queries.GetStorageDomainWipeAfterDeleteParameters; Line 5: Line 6: public class GetStorageDomainWipeAfterDeleteQuery<P extends GetStorageDomainWipeAfterDeleteParameters> Please change query name to GetStorageDomainDefaultWipeAfterDeleteQuery Line 7: extends QueriesCommandBase<P> { Line 8: Line 9: public GetStorageDomainWipeAfterDeleteQuery(P parameters) { Line 10: super(parameters); http://gerrit.ovirt.org/#/c/36526/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStorageDomainWipeAfterDeleteParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStorageDomainWipeAfterDeleteParameters.java: Line 1: package org.ovirt.engine.core.common.queries; Line 2: Line 3: import org.ovirt.engine.core.common.businessentities.StorageType; Line 4: Line 5: public class GetStorageDomainWipeAfterDeleteParameters extends VdcQueryParametersBase { Also here GetStorageDomainDefaultWipeAfterDeleteParameter Line 6: Line 7: private static final long serialVersionUID = 6469435734937894858L; Line 8: private StorageType storageType; Line 9: http://gerrit.ovirt.org/#/c/36526/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java: Line 282: GetNetworksByIscsiBondId, Line 283: GetStorageDomainsWithAttachedStoragePoolGuid, Line 284: GetFileStorageDomainsWithAttachedStoragePoolGuid, Line 285: GetBlockStorageDomainsWithAttachedStoragePoolGuid, Line 286: GetStorageDomainWipeAfterDelete, Also here Line 287: Line 288: // Event Notification Line 289: GetEventSubscribersBySubscriberIdGrouped, Line 290: http://gerrit.ovirt.org/#/c/36526/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 2575: Line 2576: Frontend.getInstance().runQuery(VdcQueryType.GetPermittedStorageDomainsByStoragePoolId, params, aQuery); Line 2577: } Line 2578: Line 2579: public void getStorageDomainWipeAfterDelete(AsyncQuery aQuery, StorageType storageType) { Here also *DefaultWipeAfterDelete Line 2580: aQuery.converterCallback = new IAsyncConverter<Boolean>() { Line 2581: @Override public Boolean Convert(Object returnValue, AsyncQuery asyncQuery) { Line 2582: return (Boolean) returnValue; Line 2583: } http://gerrit.ovirt.org/#/c/36526/8/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java: Line 102: FlowPanel specificStorageTypePanel; Line 103: Line 104: @UiField Line 105: @Ignore Line 106: AdvancedParametersExpander wipeAfterDeleteExpander; Please change the variable name to "advancedParametersExpander" as it is the content widget for the whole part, not only for WAD Line 107: Line 108: @UiField Line 109: @Ignore Line 110: FlowPanel wipeAfterDeleteExpanderContent; Line 106: AdvancedParametersExpander wipeAfterDeleteExpander; Line 107: Line 108: @UiField Line 109: @Ignore Line 110: FlowPanel wipeAfterDeleteExpanderContent; Same here Line 111: Line 112: @UiField Line 113: @Path(value = "wipeAfterDelete.entity") Line 114: @WithElementId("wipeAfterDelete") Line 128: public StoragePopupView(EventBus eventBus, ApplicationResources resources, ApplicationConstants constants) { Line 129: super(eventBus, resources); Line 130: initListBoxEditors(constants); Line 131: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this)); Line 132: initWipeAfterDeleteExpander(); Same here Line 133: ViewIdHandler.idHandler.generateAndSetIds(this); Line 134: asWidget().enableResizeSupport(true); Line 135: localize(constants); Line 136: addStyles(); -- To view, visit http://gerrit.ovirt.org/36526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0bf6a95eb4b33867de86e99f8cb59eec0d1cdd4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
