Sharad Mishra has uploaded a new change for review.
Change subject: core: Remove deprecated StringHelper in
AddSANStorageDomainCommand.
......................................................................
core: Remove deprecated StringHelper in AddSANStorageDomainCommand.
Replaced StringHelper with StringUtils
Change-Id: I8e7b8d6e28a72bcfa98ddfa1b5e27b35e98b0a17
Signed-off-by: Sharad Mishra <snmis...@linux.vnet.ibm.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/37/7237/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java
index ecfeead..1a0f980b 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java
@@ -1,5 +1,6 @@
package org.ovirt.engine.core.bll.storage;
+import org.apache.commons.lang.StringUtils;
import org.ovirt.engine.core.bll.Backend;
import org.ovirt.engine.core.common.action.AddSANStorageDomainParameters;
import org.ovirt.engine.core.common.businessentities.LUNs;
@@ -8,7 +9,6 @@
import org.ovirt.engine.core.common.vdscommands.VDSCommandType;
import org.ovirt.engine.core.common.vdscommands.VDSReturnValue;
import org.ovirt.engine.core.compat.Guid;
-import org.ovirt.engine.core.compat.StringHelper;
import org.ovirt.engine.core.dal.VdcBllMessages;
import org.ovirt.engine.core.dal.dbbroker.DbFacade;
import org.ovirt.engine.core.utils.transaction.TransactionMethod;
@@ -40,10 +40,10 @@
getStorageDomain().setstorage("");
AddStorageDomainInDb();
getStorageDomain().setstorage(storage);
- if (StringHelper.isNullOrEmpty(getStorageDomain().getstorage())) {
+ if (StringUtils.isEmpty(getStorageDomain().getstorage())) {
getStorageDomain().setstorage(CreateVG());
}
- if (!StringHelper.isNullOrEmpty(getStorageDomain().getstorage()) &&
(AddStorageDomainInIrs())) {
+ if (!StringUtils.isEmpty(getStorageDomain().getstorage()) &&
(AddStorageDomainInIrs())) {
DbFacade.getInstance().getStorageDomainStaticDAO().update(getStorageDomain().getStorageStaticData());
UpdateStorageDomainDynamicFromIrs();
ProceedVGLunsInDb();
@@ -88,8 +88,8 @@
protected boolean CanAddDomain() {
boolean returnValue = true;
// !AddSANStorageDomainParametersValue.IsExistingStorageDomain &&
- if (((getParameters().getLunIds() == null ||
getParameters().getLunIds().isEmpty()) && StringHelper
- .isNullOrEmpty(getStorageDomain().getstorage()))) {
+ if (((getParameters().getLunIds() == null ||
getParameters().getLunIds().isEmpty()) && StringUtils
+ .isEmpty(getStorageDomain().getstorage()))) {
returnValue = false;
addCanDoActionMessage(VdcBllMessages.ERROR_CANNOT_CREATE_STORAGE_DOMAIN_WITHOUT_VG_LV);
}
--
To view, visit http://gerrit.ovirt.org/7237
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e7b8d6e28a72bcfa98ddfa1b5e27b35e98b0a17
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
