Vojtech Szocs has posted comments on this change. Change subject: webadmin: Fix UI plugin REST API / Engine session refresh issue ......................................................................
Patch Set 5: > practically, this means that if a ui-plugin will perform a rest-api call > after 'UserSessionTimeOutInterval' seconds of being idle (i.e. > rest-api-http-session is expired, but engine session still not expired yet > necessarily, per the explanation above), then we may see a browser-pop-up > asking for credentials for the rest-api. Actually, we still have the heartbeat repeated timer in place, it just works differently: * previously, each 1min, send un-conditional HTTP request to REST root URL /api * now, each 1min, if there was "refreshing" operation (action/query) in past 1min, send HTTP request to REST root URL /api So we are NOT sending REST "keepalive" request on each "refreshing" operation (action/query) execution, but max. once per 1min. Because of this, REST session is refreshed *after* Engine session is refreshed, so the scenario you wrote above is not possible, I think. -- To view, visit http://gerrit.ovirt.org/36622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ffd3198239040f67313238a837af98db16e79ea Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
