Shahar Havivi has posted comments on this change.

Change subject: UI: change Make-Template to more readable text (#848104)
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
Line 669:                 new AddVmTemplateParameters(newvm,
Line 670:                         (String) model.getName().getEntity(),
Line 671:                         (String) model.getDescription().getEntity());
Line 672: 
Line 673:         addVmTemplateParameters.setPublicUse(!(Boolean) 
model.getIsTemplatePublic().getEntity());
right,
the ! is not needed
Line 674: 
Line 675:         if (model.getQuota().getSelectedItem() != null) {
Line 676:             newvm.setQuotaId(((Quota) 
model.getQuota().getSelectedItem()).getId());
Line 677:         }


--
To view, visit http://gerrit.ovirt.org/7216
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9055763d66b09da175810ad3ba2ace0ff8316264
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to