Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL query to get volume snapshot configurations ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/36292/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSnapshotConfigQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSnapshotConfigQuery.java: Line 37: } Line 38: } Line 39: getQueryReturnValue().setReturnValue(new Pair<List<GlusterVolumeSnapshotConfig>, List<GlusterVolumeSnapshotConfig>>(clusterCfgs, Line 40: volumeCfgs)); Line 41: } else { > what happens when the cluster config is already in db but volume config is In current scenario next sync would make sure all the configurations are in sync. Till the sync happens the if part would return only cluster configurations and user can modify them only. But once we segregate volume and cluster configurations as two different options, this situation should not arise. Line 42: String volumeName = volumeId == null ? "" : getGlusterVolumeDao().getById(volumeId).getName(); Line 43: Guid serverId = getRandomUpServerId(clusterId); Line 44: if (serverId == null) { Line 45: return; Line 40: volumeCfgs)); Line 41: } else { Line 42: String volumeName = volumeId == null ? "" : getGlusterVolumeDao().getById(volumeId).getName(); Line 43: Guid serverId = getRandomUpServerId(clusterId); Line 44: if (serverId == null) { > You could send this error in the return value, so that the ui can understan Will try that Line 45: return; Line 46: } Line 47: Line 48: VDSReturnValue returnValue = runVdsCommand(VDSCommandType.GetGlusterVolumeSnapshotConfigInfo, -- To view, visit http://gerrit.ovirt.org/36292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4374b51297549731bc6c93c8a72b033ca64fdfef Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
