Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL query to get volume snapshot configurations ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36292/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSnapshotConfigQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSnapshotConfigQuery.java: Line 42: String volumeName = volumeId == null ? "" : getGlusterVolumeDao().getById(volumeId).getName(); Line 43: Guid serverId = getRandomUpServerId(clusterId); Line 44: VDSReturnValue returnValue = runVdsCommand(VDSCommandType.GetGlusterVolumeSnapshotConfigInfo, Line 45: new GlusterVolumeSnapshotVDSParameters(serverId, volumeName, clusterId)); Line 46: if (returnValue.getSucceeded()) { > will try that The sync job fetches details for the full cluster and all its volumes, whereas here we are fetching only volume specific configurations. Not sure if we should use the sync job method here. What you say ? Line 47: GlusterSnapshotConfigInfo fetchedConfigInfo = (GlusterSnapshotConfigInfo) returnValue.getReturnValue(); Line 48: if (fetchedConfigInfo != null) { Line 49: Map<String, String> fetchedClusterConfigs = fetchedConfigInfo.getClusterConfigOptions(); Line 50: for (String key : fetchedClusterConfigs.keySet()) { -- To view, visit http://gerrit.ovirt.org/36292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4374b51297549731bc6c93c8a72b033ca64fdfef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
