Greg Sheremeta has posted comments on this change. Change subject: WIP: new Tooltip infrastructure ......................................................................
Patch Set 3: > sluggish times are configurable. Fading in/out is by design. I think the current implementation where it instantly opens at you is harsh / scary. > it takes them a little bit of time to appear after hovering on the icon. by design. See https://bugzilla.redhat.com/show_bug.cgi?id=1023549 > a tooltip may appear when the user has already hovered-out of the relevant > icon. a bug, can fix > two tool-tips may appear at the same time. is that a problem? > tool-tips may take a significant amount of time to disappear. 1 second is by design (https://bugzilla.redhat.com/show_bug.cgi?id=1023549) if they take longer, it's because a grid refresh happened. currently i have the reaper set to 5 seconds or something, but we could have it shorter or even near-instant. > and this is only what I discovered in very few minutes of testing this patch > - I'm afraid that the current implementation is less-than-ideal from a UX > perspective, and may be prone to unexpected behaviors and users' complaints. that's why the patch is marked "WIP" :) I have much to fix. > With your patch applied: are there any PatternFly tool-tips in the GUI that > are not in a grid? Not sure. > Assuming tool-tips behave seamlessly in the GUI in locations other than the > grids: I am wondering whether we should, for now, "fallback" to native > browser tool-tips in the grids, and migrate to PatternFly tool-tips only in > places that are not re-rendered upon refresh [e.g. dialogs, action-buttons > (?), etc.] I think that's dramatic given that the issues are small. Since this is a 3.6 feature, we have plenty of time to fix any bugs or issues that come up. But I defer to you :) -- To view, visit http://gerrit.ovirt.org/36530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f82efada76f8b4654f034c428246f27ebe55889 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
