Martin Peřina has posted comments on this change. Change subject: Engine: Add unit-tests for fence execution ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/36494/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java: Line 30: private FencingPolicy fencingPolicy; Line 31: private FenceProxyLocator proxyLocator; Line 32: private VdsArchitectureHelper architectureHelper; Line 33: Line 34: public FenceExecutor(VDS vds) { Please add here this(vds, null); and move rest of the code into 2nd constructor. Using this approach we can get rid of FindBugs error. Line 35: // TODO remove if block after UI patch that should set also cluster & proxy preferences in GetNewVdsFenceStatusParameters Line 36: if (! vds.getId().equals(Guid.Empty)) { Line 37: VDS dbVds = DbFacade.getInstance().getVdsDao().get(vds.getId()); Line 38: if (vds.getVdsGroupId() == null) { Line 47: this.architectureHelper = new VdsArchitectureHelper(); Line 48: } Line 49: Line 50: public FenceExecutor(VDS vds, FencingPolicy fencingPolicy) { Line 51: this(vds); Please change to: this.vds = vds; Line 52: this.fencingPolicy = fencingPolicy; Line 53: } Line 54: Line 55: /** -- To view, visit http://gerrit.ovirt.org/36494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I311933f0e3d23489c44faa6dced4373f7254b56e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
