Martin Peřina has posted comments on this change.

Change subject: Engine: Add unit-tests for fence execution
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36494/1/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceExecutorTest.java
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceExecutorTest.java:

Line 64:     @Mock
Line 65:     private DbFacade dbFacade;
Line 66: 
Line 67:     @Mock
Line 68:     private VDS vds;
> That's not true, this vds is used everywhere
Ahh, sorry, my mistake, this rename comment should be placed only for 
FenceProxyLocatorTest in patch 36419
Line 69: 
Line 70:     @Mock
Line 71:     private VdsDAO vdsDao;
Line 72: 


-- 
To view, visit http://gerrit.ovirt.org/36494
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I311933f0e3d23489c44faa6dced4373f7254b56e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to