Allon Mureinik has posted comments on this change. Change subject: core: Make ConfigValuesTest more informative ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/36551/2/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/ConfigValuesTest.java File backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/ConfigValuesTest.java: Line 15: private static final Logger log = LoggerFactory.getLogger(ConfigValuesTest.class); Line 16: private static final Set<String> configValuesEnumNames = getConfigValuesEnumNames(); Line 17: Line 18: private static Set<String> getConfigValuesEnumNames() { Line 19: Set<String> configValuesEnumNames = new HashSet<String>(); May be worth while changing this one to a TreeSet too, but in a different patch. Line 20: for (ConfigValues configValue : ConfigValues.values()) { Line 21: configValuesEnumNames.add(configValue.toString()); Line 22: } Line 23: return configValuesEnumNames; -- To view, visit http://gerrit.ovirt.org/36551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb921f082350d19006c7b977c2697009bbc2a10d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
