Oved Ourfali has posted comments on this change. Change subject: core: Make ConfigValuesTest more informative ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36551/1/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/ConfigValuesTest.java File backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/ConfigValuesTest.java: Line 31: List<ConfigurationValues> missingKeys = new ArrayList<ConfigurationValues>(); Line 32: for (ConfigurationValues configValue : ConfigurationValues.values()) { Line 33: if (!configValuesEnumNames.contains(configValue.toString())) { Line 34: log.error("Found missing key: {}", configValue); Line 35: foundMissingKeys = true; so I guess we don't need this boolean anymore? Line 36: missingKeys.add(configValue); Line 37: break; Line 38: } Line 39: } -- To view, visit http://gerrit.ovirt.org/36551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb921f082350d19006c7b977c2697009bbc2a10d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
