Shubhendu Tripathi has posted comments on this change. Change subject: gluster: VDS Command - Gluster vol snapshot create ......................................................................
Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/23212/15/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CreateGlusterVolumeSnapshotVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CreateGlusterVolumeSnapshotVDSCommand.java: Line 30: proceedProxyReturnValue(); Line 31: Line 32: if (getVDSReturnValue().getSucceeded()) { Line 33: snapshot.setId(Guid.createGuidFromStringDefaultEmpty(uuidReturn.mUuid)); Line 34: setReturnValue(snapshot); > setReturnValue can be Guid? As the snapshot entity is not populated apart f not exactly. will change to return Guid only. Line 35: } Line 36: } -- To view, visit http://gerrit.ovirt.org/23212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib610f49c3b6c5aa108ce6fef0291cd9693429197 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
