Piotr Kliczewski has posted comments on this change. Change subject: gluster: VDS Command - Gluster vol snapshot create ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/23212/17/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CreateGlusterVolumeSnapshotVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CreateGlusterVolumeSnapshotVDSCommand.java: Line 21: protected void executeVdsBrokerCommand() { Line 22: String volumeName = getParameters().getVolumeName(); Line 23: String snapshotName = getParameters().getSnapshotName(); Line 24: String description = getParameters().getDescription() == null ? "" : getParameters().getDescription(); Line 25: boolean force = getParameters().getForce() ? true : false; getForce() returns boolean we do not need to double check. Line 26: uuidReturn = getBroker().glusterSnapshotCreate(volumeName, snapshotName, description, force); Line 27: proceedProxyReturnValue(); Line 28: Line 29: if (getVDSReturnValue().getSucceeded()) { -- To view, visit http://gerrit.ovirt.org/23212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib610f49c3b6c5aa108ce6fef0291cd9693429197 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
