Martin Peřina has posted comments on this change. Change subject: core: fix non-responding logging in case of no PM ......................................................................
Patch Set 2: Code-Review+1 (2 comments) Minor formatting issues http://gerrit.ovirt.org/#/c/36397/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 750: private void logHostNonResponding(long timeoutToFence) { Line 751: String msg; Line 752: AuditLogType auditLogType; Line 753: Line 754: if ( cachedVds.getpm_enabled()) { Please remove space after ( if (cachedVds.getpm_enabled()) { Line 755: msg = "Host '{}' is not responding. It will stay in Connecting state for a grace period " + Line 756: "of {} seconds and after that an attempt to fence the host will be issued."; Line 757: auditLogType = AuditLogType.VDS_HOST_NOT_RESPONDING_CONNECTING; Line 758: log.warn(msg, cachedVds.getName(), TimeUnit.MILLISECONDS.toSeconds(timeoutToFence)); Line 756: "of {} seconds and after that an attempt to fence the host will be issued."; Line 757: auditLogType = AuditLogType.VDS_HOST_NOT_RESPONDING_CONNECTING; Line 758: log.warn(msg, cachedVds.getName(), TimeUnit.MILLISECONDS.toSeconds(timeoutToFence)); Line 759: } Line 760: else { Please reformat else block: } else { ... Line 761: msg = "Host '{}' is not responding."; Line 762: auditLogType = AuditLogType.VDS_HOST_NOT_RESPONDING; Line 763: log.warn(msg, cachedVds.getName()); Line 764: } -- To view, visit http://gerrit.ovirt.org/36397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f7e7a9987be93023309c0b25f35d856d2ec1f04 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
