Martin Peřina has posted comments on this change. Change subject: core: fix non-responding logging in case of no PM ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36397/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 746: logable.updateCallStackFromThrowable(ex); Line 747: AuditLogDirector.log(logable, AuditLogType.VDS_FAILURE); Line 748: } Line 749: Line 750: private void logHostNonResponding(long timeoutToFence, VDS host) { Please choose one of: 1. Use instance variable cachedVDS in this method 2. You added VDS host parameter, so use it exclusively in this method and don't mic usage of host and cachedVDS Line 751: String msg; Line 752: AuditLogType auditLogType; Line 753: Line 754: if ( host.getpm_enabled()) { -- To view, visit http://gerrit.ovirt.org/36397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f7e7a9987be93023309c0b25f35d856d2ec1f04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
