Liron Aravot has posted comments on this change. Change subject: core: Message fixing for adding an ISO domain on a block domain. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36399/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java: Line 157: } Line 158: if (getStorageDomain().getStorageDomainType() == StorageDomainType.ISO Line 159: && !getStorageDomain().getStorageType().isFileDomain()) { Line 160: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DOMAIN_TYPE_CAN_BE_CREATED_ONLY_ON_SPECIFIC_STORAGE_DOMAINS, Line 161: String.format("$domainType %1$s", "ISO"), let's have those as constants (for example in StorageConstants) so they can be later re-used and the usages could be found more easily. Line 162: String.format("$storageTypes %1$s", "file")); Line 163: } Line 164: if (getStorageDomain().getStorageDomainType() == StorageDomainType.ImportExport Line 165: && (getStorageDomain().getStorageType() == StorageType.LOCALFS || getStorageDomain().getStorageType().isBlockDomain())) { -- To view, visit http://gerrit.ovirt.org/36399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5b3dc26fb21a876ce6adaa50ec6c35bc38ce0b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
