Amit Aviram has uploaded a new change for review.
Change subject: core: Message fixing for adding an ISO domain on a block domain.
......................................................................
core: Message fixing for adding an ISO domain on a block domain.
Adding an ISO domain on a block domain which is not supported gave an
uninformative error message. the message was replaced to another message
which fits better to this action.
Change-Id: Id5b3dc26fb21a876ce6adaa50ec6c35bc38ce0b1
Signed-off-by: Amit Aviram <aavi...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/99/36399/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
index 43f9c6a..0a53f72 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
@@ -157,7 +157,9 @@
}
if (getStorageDomain().getStorageDomainType() == StorageDomainType.ISO
&& !getStorageDomain().getStorageType().isFileDomain()) {
- return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL);
+ return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DOMAIN_TYPE_CAN_BE_CREATED_ONLY_ON_SPECIFIC_STORAGE_DOMAINS,
+ String.format("$domainType %1$s", "ISO"),
+ String.format("$storageTypes %1$s", "file"));
}
if (getStorageDomain().getStorageDomainType() ==
StorageDomainType.ImportExport
&& (getStorageDomain().getStorageType() == StorageType.LOCALFS
|| getStorageDomain().getStorageType().isBlockDomain())) {
--
To view, visit http://gerrit.ovirt.org/36399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5b3dc26fb21a876ce6adaa50ec6c35bc38ce0b1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aavi...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
